-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit rpc endpoints using command #1292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes look good, but I think we need to also reinitialize the rpc client and the light provider in the CosmosProvider
and PenumbraProvider
after changing the rpc addr
relayer/relayer/chains/cosmos/provider.go
Lines 275 to 283 in 892e52c
rpcClient, err := NewRPCClient(cc.PCfg.RPCAddr, timeout) | |
if err != nil { | |
return err | |
} | |
lightprovider, err := prov.New(cc.PCfg.ChainID, cc.PCfg.RPCAddr) | |
if err != nil { | |
return err | |
} |
not sure how this will effect the relayer during runtime though.
This should not be required since it is only updating the config file, not interacting with the running relayer. The relayer will still require a restart after this. |
makes sense to me! |
Example
"rly chains set-rpc-addr ibc-0 https://abc.xyz.com:443"
This resolves part III of #887