Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit rpc endpoints using command #1292

Merged
merged 7 commits into from
Oct 12, 2023
Merged

edit rpc endpoints using command #1292

merged 7 commits into from
Oct 12, 2023

Conversation

vimystic
Copy link
Contributor

Example
"rly chains set-rpc-addr ibc-0 https://abc.xyz.com:443"

This resolves part III of #887

Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good, but I think we need to also reinitialize the rpc client and the light provider in the CosmosProvider and PenumbraProvider after changing the rpc addr

rpcClient, err := NewRPCClient(cc.PCfg.RPCAddr, timeout)
if err != nil {
return err
}
lightprovider, err := prov.New(cc.PCfg.ChainID, cc.PCfg.RPCAddr)
if err != nil {
return err
}

not sure how this will effect the relayer during runtime though.

@agouin
Copy link
Member

agouin commented Oct 11, 2023

the changes look good, but I think we need to also reinitialize the rpc client and the light provider in the CosmosProvider and PenumbraProvider after changing the rpc addr

rpcClient, err := NewRPCClient(cc.PCfg.RPCAddr, timeout)
if err != nil {
return err
}
lightprovider, err := prov.New(cc.PCfg.ChainID, cc.PCfg.RPCAddr)
if err != nil {
return err
}

not sure how this will effect the relayer during runtime though.

This should not be required since it is only updating the config file, not interacting with the running relayer. The relayer will still require a restart after this.

@jtieri
Copy link
Member

jtieri commented Oct 11, 2023

the changes look good, but I think we need to also reinitialize the rpc client and the light provider in the CosmosProvider and PenumbraProvider after changing the rpc addr

rpcClient, err := NewRPCClient(cc.PCfg.RPCAddr, timeout)
if err != nil {
return err
}
lightprovider, err := prov.New(cc.PCfg.ChainID, cc.PCfg.RPCAddr)
if err != nil {
return err
}

not sure how this will effect the relayer during runtime though.

This should not be required since it is only updating the config file, not interacting with the running relayer. The relayer will still require a restart after this.

makes sense to me!

@jtieri jtieri enabled auto-merge (squash) October 12, 2023 16:42
@jtieri jtieri merged commit cb4708b into cosmos:main Oct 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants