-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compliant with the REUSE specification #300
Conversation
Pull Request Test Coverage Report for Build 3184185550
💛 - Coveralls |
Is there a guideline for which file is licensed under which license? Because some config files are CC and others are MIT. |
There should be no config files under CC-BY, however there are some under CC0. There is no real guideline on when to choose which. However, there are two reasons due to which we may decide to publish a specific file under CC0 rather than MIT:
Therefore, I put very simple files and our configuration files (not the vista xml's, they actually contain complex logic) under the CC0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most change requests are adding new lines at the end if .license files.
Thank you for the review! Why do we want to have newlines in those files? They are auto-generated anyways (via |
Co-authored-by: Jonas Gilg <[email protected]>
Co-authored-by: Jonas Gilg <[email protected]>
Co-authored-by: Jonas Gilg <[email protected]>
Co-authored-by: Jonas Gilg <[email protected]>
Ok, I think we can leave it then. GitHub suggested these changes, so I went with it. |
This makes CosmoScout VR compliant with the REUSE Specification of the Free Software Foundation Europe.
This requires #298 to be merged first.Some additional changes:
eslint
files were removed as we are usingclang-format
to format the JavaScript files.