Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compliant with the REUSE specification #300

Merged
merged 19 commits into from
Oct 5, 2022
Merged

Conversation

Schneegans
Copy link
Member

@Schneegans Schneegans commented Oct 4, 2022

This makes CosmoScout VR compliant with the REUSE Specification of the Free Software Foundation Europe.

  • It is now clear for each and every file
    • Who is the copyright holder?
    • What is the license for the file?
  • There's a new CI job which enforces this.
  • There's a new badge in the README to show the status.

This requires #298 to be merged first.

Some additional changes:

  • The Vive controller model was removed due to the unclear licensing.
  • Some moon textures have been removed due to unclear licenses.
  • Some eslint files were removed as we are using clang-format to format the JavaScript files.

@Schneegans Schneegans added this to the Version 1.6.0 milestone Oct 4, 2022
Base automatically changed from feature/refactor-celestial-anchors to develop October 4, 2022 07:31
@coveralls
Copy link

coveralls commented Oct 4, 2022

Pull Request Test Coverage Report for Build 3184185550

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.0002%) to 3.011%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/csp-lod-bodies/src/PlanetShader.cpp 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
plugins/csp-anchor-labels/src/AnchorLabel.cpp 1 0%
Totals Coverage Status
Change from base Build 3180237718: -0.0002%
Covered Lines: 491
Relevant Lines: 16306

💛 - Coveralls

@Schneegans Schneegans marked this pull request as ready for review October 4, 2022 09:32
@Schneegans Schneegans requested a review from JonasGilg October 4, 2022 09:32
@JonasGilg
Copy link
Member

JonasGilg commented Oct 4, 2022

Is there a guideline for which file is licensed under which license? Because some config files are CC and others are MIT.

@Schneegans
Copy link
Member Author

Is there a guideline for which file is licensed under which license? Because some config files are CC and others are MIT.

There should be no config files under CC-BY, however there are some under CC0.

There is no real guideline on when to choose which. However, there are two reasons due to which we may decide to publish a specific file under CC0 rather than MIT:

  • The file is extremely simple. This is the case for our .gitignore file etc. These files do not meet a certain "threshold of originality" and are therefore not really copyrightable (see here).
  • The file is very likely to be adapted by the user. For example, our scene configuration file will likely be the basis for a scene configuration file of a user. If we put it under the MIT, the user will always need to specify this which would b a pretty useless burden.

Therefore, I put very simple files and our configuration files (not the vista xml's, they actually contain complex logic) under the CC0.

Copy link
Member

@JonasGilg JonasGilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most change requests are adding new lines at the end if .license files.

docs/plugins.md Outdated Show resolved Hide resolved
src/cosmoscout/icon.rc Outdated Show resolved Hide resolved
test/cs-utils/filesystem.cpp Outdated Show resolved Hide resolved
tools/New-Plugin.ps1 Show resolved Hide resolved
@Schneegans
Copy link
Member Author

Schneegans commented Oct 4, 2022

Thank you for the review! Why do we want to have newlines in those files? They are auto-generated anyways (via reuse addheader --copyright="German Aerospace Center (DLR) <[email protected]>" --license="CC0-1.0" <binary file>). I think it would be a bit cumbersome if we want to have those newlines everywhere...

@JonasGilg
Copy link
Member

Thank you for the review! Why do we want to have newlines in those files? They are auto-generated anyways (via reuse addheader --copyright="German Aerospace Center (DLR) <[email protected]>" --license="CC0-1.0" <binary file>). I think it would be a bit cumbersome if we want to have those newlines everywhere...

Ok, I think we can leave it then. GitHub suggested these changes, so I went with it.

@Schneegans Schneegans merged commit 762fc8d into develop Oct 5, 2022
@Schneegans Schneegans deleted the feature/reuse branch October 5, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants