-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fancy stars #396
Open
Schneegans
wants to merge
61
commits into
main
Choose a base branch
from
feature/fancy-stars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fancy stars #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12690840035Details
💛 - Coveralls |
It looks really awesome! While running it I couldn't find any bugs. I just noticed, that the loading time on first startup is REALLY slow. The CPU seems to be the bottleneck. Is it possible to improve the first startup time with some multithreading? I will review the code next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does three main things:
SR-Points
andGlare Disc
.See below for more details.
Other Changes
SR-Points
rendering method is now the default for the star rendering.1. Glare Performance Improvements
The glare computation is now much faster.
There are a couple of reasons for this:
2. New Star Rendering Methods
Glare Disc
This method renders the stars as camera facing billboards. The center of the billboard contains a star which looks like the
Smooth Disc
method. However, the billboard of bright stars is made slightly larger, and a glare effect is added to the star. This makes them look almost like theSmooth Disc
method when the glare is enabled, but without requiring the glare computation. This makes them look quite cool in non-HDR mode where the glare is not computed.SR-Points
This is a very advanced alternative star rendering method.
"SR" stands for "software rasterizer" which is a technique to render the stars using a compute shader instead of the traditional rasterization pipeline.
This makes it very efficient to discard stars which are either too dim to be seen or out of the frustum.
This way, we can draw significantly more stars in one draw call than before.
Besides, this mode can render the stars extremely small, but not too small.
Our smallest stars we had before were 1 pixel in size but suffered from aliasing when moving slowly across the screen.
Our new software rasterizer distributes the luminance of a star over an area of 2x2 pixels based on the subpixel position of the star. This makes the stars look much better when moving slowly across the screen than with the previous GL_POINTS method.
3. Gaia DR3
To test this new rendering method, we created a subset of the Gaia DR3 catalogue which contains several tens of millions of the brightest stars.
The PR contains code to load these subsets, however we are still thinking about how to provide the data to the user, as these catalogues are quite large, and we don't want to ship them with the application.