Fixes for home assistant

[tljdebrouwer]

Hello,

While integrating the newest version with HA I got the following error:

"TypeError: backoff.on_exception applied to a regular function inside coroutine, this will lead to event loop hiccups. Use backoff.on_exception on coroutines in asynchronous code."

on

@backoff.on_exception(backoff.expo, IncompleteStatus)

I'm not sure why this was added in the last release? Do we really need it?

Else I would propose to remove it as in this pull request. With a local library build I was able to verify the working.

Thanks,

Tom

[costastf]

The reason why I implemented that is that on Saturday when I did the refactoring the service was almost unresponsive with huge backend issues so I implemented a backoff on things that were breaking. It does make the code more robust. I got feedback from the HA MR I created that the authentication I implemented would indeed break other implementations and I am still waiting on feedback on how to best resolve that. I will be on vacation after tomorrow until the new year so I don't see this moving forward until then.

[tljdebrouwer]

Thanks, got your point. Not sure why it doesnt work for me with this exception in HA. I did do some work on that branch, somewhat edge cases. Enjoy your holiday and lets be in touch after that.

[tljdebrouwer]

Hi,

Are you back from holiday? Can we continue to work on this?

[costastf]

Hey, yes i am, sorry this completely slipped my mind. Please have a look at home-assistant/core#29248 and get engaged on the discussion on which I still don't have an answer so we know what it is we are trying to do. I got the feeling that frenck is suggesting to implement the auth part on home assistant itself and delegate the tokens to toonapilib, in which case I need to refactor again for that purpose but it is not clear what he has in mind. I also find it difficult to communicate with him and find his communication very adversarial and not friendly so I am not really looking forward to chatting with him. If you could help there, it would be much appreciated. I am not really opinionated on how things should be implemented and don't mind implementing whatever makes sense

…

On Wed, Jan 15, 2020 at 7:59 AM Tom de Brouwer ***@***.***> wrote: Hi, Are you back from holiday? Can we continue to work on this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#47?email_source=notifications&email_token=ABDMK25YSUIT2FIOEO2TAIDQ52X3TA5CNFSM4JU5OIC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI7IUYQ#issuecomment-574524002>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDMK27SXBGVKNJUHGRUJ5TQ52X3TANCNFSM4JU5OICQ> .

[frenck]

Wow, that is nice to read here. Not sure if I deserved that in any way.
Sorry to hear that is how you think of me.

in which case I need to refactor again for that purpose but it
is not clear what he has in mind

That is a much clearer question than on the referenced PR.
Home Assistant provides OAuth2 helpers. All the OAuth2 logic is handled by HA, the tokens can be passed to the library.

Since all tenants support that, that would be ideal.

However, if you are not up for chatting with me or discussing any of that 🤷‍♂

I'm happy to pick it up.

[costastf]

Hi franck, Apologies for the public nature of the message, i answered vie email and did not really think it through. Of course i am up to chatting and discussing with anyone that uses a friendly tone with a genuine target to communicate and solve a problem. If that is your intention then by definition I do want to communicate with you. It is important to understand though that at least in my case it didn't feel like that in a few of the interactions we have had and it felt much more adversarial that it needs to be. If that is you personal style, it is fine and it might be absolutely great in a face to face discussion but through written word things get through as much drier than they actually are and I find it better to error on the side of caution (friendliness) that strict correctness. I am not aware of all the architectural choices and implementations that HA has done. I barely got the hint that it could work like that from what you said which sounded very much like you schooling me about what "proper" architecture is. If you had clearly said the above and what you would want from the library to do we could have be done by now. Last point, when there is miscommunication and misunderstanding, when your first response is, "fine, i will do it myself" it does not really convey a message of community and helping each other and it is not the first time you have reacted like that. Just my 2c. If you feel that the matter could use more communication I would be very happy to take this off line. After all we are both putting in our personal time for the benefit of others along with scratching our personal itch and i think that that could be a common ground. kind regards Costas

…

On Wed, Jan 15, 2020 at 11:48 AM Franck Nijhof ***@***.***> wrote: Wow, that is nice to read here. Not sure if I deserved that in any way. Sorry to hear that is how you think of me. in which case I need to refactor again for that purpose but it is not clear what he has in mind That is a much clearer question than on the referenced PR. Home Assistant provides OAuth2 helpers. All the OAuth2 logic is handled by HA, the tokens can be passed to the library. Since all tenants support that, that would be ideal. However, if you are not up for chatting with me or discussing any of that 🤷‍♂ I'm happy to pick it up. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#47?email_source=notifications&email_token=ABDMK224PUNIYD5ULH4RFKTQ53SWBA5CNFSM4JU5OIC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI74LVY#issuecomment-574604759>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDMK22MXJ2NNHPCMKMFLBLQ53SWBANCNFSM4JU5OICQ> .