Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on setup page, fix missing save icon on Update tab, save configuration button, #20

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

rob040
Copy link
Contributor

@rob040 rob040 commented Jan 8, 2024

On setup page, fix missing save icon on Update tab, save configuration button,
and align "Store wifi credentials" switch to left and look same as other input fields.

app.js: duplicate svg-save ref to svg-save2, hide save button when no-dhcp is disabled; other deltas are white space/tabs
setup.htm: duplicate svg-save ref to svg-save2,

see also issue #19

…n button,

and align "Store wifi credentials" switch to left and look same as other input fields.
app.js: duplicate svg-save ref to svg-save2, hide save button when no-dhcp is disabled; other deltas are whithespace/tabs
setup.htm: duplicate svg-save ref to svg-save2,
@cotestatnt
Copy link
Owner

Hi @rob040
The appearance of the checkbox in question was deliberately left different to give it a different visibility and also because with the right alignment the page seems more "harmonious" according to my aesthetic taste. In any case, I take the proposal into consideration and we will evaluate it.

As for the button, you need to leave it visible because if the no-dhcp option was active and you want to disable, you still need to save. Hiding the button can give the user the impression that it is not necessary and leave it on true in the /config.json file.

For the missing icon, something went wrong with the latest updates made to the page.
The button you see is the same one that is simply moved to the box where it is needed and therefore it should not be necessary to duplicate it.

I would like to check better what I've done before, because in theory it shouldn't happen.

@cotestatnt
Copy link
Owner

The button you see is the same one that is simply moved to the box

I wrote something incorrect, sorry. This was my first intention, but then it turned out to be easier to duplicate the button

@cotestatnt cotestatnt mentioned this pull request Jan 9, 2024
@cotestatnt cotestatnt merged commit 0996616 into cotestatnt:master Jan 10, 2024
20 checks passed
@rob040 rob040 deleted the setupPageFix branch January 10, 2024 12:14
@rob040 rob040 restored the setupPageFix branch January 21, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants