CouchbaseCache modifies meta.expiration value of a document during cache read operation #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CouchbaseCache
class that implements standardIDistributedCache
interface overwrites meta.expiration on every cache read.IMO this is incorrect behavior and it leads to lots of surprises and not consistent with other popular implementation like StackExchange.Redis.
The problem comes from this explicit interface implementation method:
There's no obvious explanation of why
collection.GetAndTouchAsync()
is used instead ofcollection.GetAsync()
plus passing Options.LifeSpan.GetValueOrDefault() simply resets the cache lifetime to 20 minutes on every cache read.In many real use cases cache entry lifetime is selected carefully depending on what data is cached and absolute expiration datetime should be preserved.
Can we just remove explicit interface implementation and just keep GetAsync() insteadl? As far as I can see it also handled DocumentNotFoundException and returns null to indicate that there's no entity in the case which is already inline with expected behavior of
IDistributedCache.GetAsync()
.