Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better certificate support #59

Merged
merged 12 commits into from
Jan 29, 2025
Merged

Conversation

glennga
Copy link
Collaborator

@glennga glennga commented Jan 24, 2025

  • fix to provider + auditor to use certificate, use of 'get(item_type)' instead of get_item
  • allow the specification of certificates for SQL++ tools and semantic search tools
  • view DDL file updates to use scoped names

@glennga glennga requested review from TJ202 and ThejasNU January 24, 2025 22:27
Copy link
Collaborator

@ThejasNU ThejasNU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better if use of certificate is included in generated python code of sqlpp and http tool in this patch

glennga and others added 7 commits January 27, 2025 13:31
Adding PRIMARY INDEX creation to metadata catalogs.
Modifying view files to use the proper scopes.
* Adding notice

* Removed wrong notice

* Added makefile to install agentc using pip in conda env

* add poetry install

* Added makefiles for starter agents, modified makefile to include variable env name

* Updated readmes to include makefile

* Modified readmes to give opt bw makefile and manual installation

---------

Co-authored-by: ThejasNU <[email protected]>
* Adding notice

* Removed wrong notice

* Added makefile to install agentc using pip in conda env

* add poetry install

* Added makefiles for starter agents, modified makefile to include variable env name

* Updated readmes to include makefile

* Modified readmes to give opt bw makefile and manual installation

* Updated docs with makefile instructions

---------

Co-authored-by: ThejasNU <[email protected]>
* Adding notice

* Removed wrong notice

* Adding analytics view

* minor changes

* updating view to use a single GROUP BY

* Creating views in the keyspace given now

---------

Co-authored-by: Glenn Galvizo <[email protected]>
* Adding notice

* Removed wrong notice

* Added sphinx doc and updated llmgen keyspace
@glennga glennga changed the title small agentc module class changes (fix to provider + auditor to use c… better certificate support Jan 27, 2025
@glennga glennga requested a review from ThejasNU January 27, 2025 21:44
Copy link
Collaborator

@ThejasNU ThejasNU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@TJ202
Copy link
Collaborator

TJ202 commented Jan 29, 2025

do we wish to push the get(item_type) instead of get_item() fix to master now?
since agentc v0 is out for private preview, might be misleading?
@glennga @ThejasNU

Copy link
Collaborator

@ThejasNU ThejasNU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any code for get(item_type) change

@glennga glennga merged commit 1b61def into master Jan 29, 2025
5 checks passed
@ThejasNU ThejasNU deleted the glennga/auditor_provider_fixes_1 branch January 30, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants