fix pipeline tests + refactor state table init

lib/rudder/pipeline.ex

@@ -160,33 +160,57 @@ defmodule Rudder.Pipeline do
     Logger.warn("key #{bsp_key} written to backlog with #{urls}; error: #{inspect(err)}")
   end
 
-  def init_state() do
+  defp init_state() do
     GVA.gnew(:state)
     GVA.gput(:state, :retry_failed_bsp, false)
     GVA.gput(:state, :bsp_upload_status, :ok)
   end
 
   def set_retry_failed_bsp() do
+    if !GVA.gexists(:state) do
+      init_state()
+    end
+
     GVA.gput(:state, :retry_failed_bsp, true)
   end
 
   def clear_retry_failed_bsp() do
+    if !GVA.gexists(:state) do
+      init_state()
+    end
+
     GVA.gput(:state, :retry_failed_bsp, false)
   end
 
   def is_retry_failed_bsp() do
+    if !GVA.gexists(:state) do
+      init_state()
+    end
+
     GVA.gget(:state, :retry_failed_bsp)
   end
 
   def is_bsp_upload_status_ok() do
+    if !GVA.gexists(:state) do
+      init_state()
+    end
+
     :ok == GVA.gget(:state, :bsp_upload_status)
   end
 
   def bsp_upload_success() do
+    if !GVA.gexists(:state) do
+      init_state()
+    end
+
     GVA.gput(:state, :bsp_upload_status, :ok)
   end
 
   def bsp_upload_failure() do
+    if !GVA.gexists(:state) do
+      init_state()
+    end
+
     GVA.gput(:state, :bsp_upload_status, :err)
   end
 end

lib/rudder/proof_chain/block_specimen_event_listener.ex

@@ -35,8 +35,6 @@ defmodule Rudder.ProofChain.BlockSpecimenEventListener do
 
     case Process.whereis(register_name) do
       nil ->
-        Logger.info("initializing state for GVA")
-        Rudder.Pipeline.init_state()
         :ok
 
       _pid ->

lib/rudder/util/util.ex

@@ -65,6 +65,15 @@ defmodule Rudder.Util do
       end
     end
 
+    @doc """
+    Check if a table exists.
+    """
+    defmacro gexists(name) do
+      quote do
+        :ets.info(unquote(name)) != :undefined
+      end
+    end
+
     @doc """
     Put a value in a variable table.
     """

test/evm/evm_test.exs

@@ -43,7 +43,10 @@ defmodule SupervisionTreeTest do
     block_id = "1234_f_"
 
     specimen = get_sample_specimen!()
-    {:ok, bpid} = Rudder.BlockProcessor.start_link(["http://evm-server:3002"])
+
+    {:ok, bpid} =
+      Rudder.BlockProcessor.start_link([Application.get_env(:rudder, :evm_server_url)])
+
     {:error, error_msg} = GenServer.call(bpid, {:process, "invalid content"}, 60_000)
 
     assert error_msg ==