Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 and v1.4 #52

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

v2.0 and v1.4 #52

wants to merge 22 commits into from

Conversation

wdes-bot
Copy link

webhat and others added 22 commits June 13, 2012 10:10
$.browser is no longer supported in jQuery 1.9+
It'll result by an error : `Cannot read property 'msie' of undefined`
We can use the MSDN detection method for IE (more info here : http://msdn.microsoft.com/en-us/library/ms537509(v=vs.85).aspx )
$.browser is no longer supported in jQuery 1.9+
It'll result by an error : `Cannot read property 'msie' of undefined`
We can use the MSDN detection method for IE (more info here : http://msdn.microsoft.com/en-us/library/ms537509(v=vs.85).aspx )
The browser interprets the occurrence of the literal "</script>" inside of the
body of a script tag as the end of the script, so the leading "<" must be
escaped by replacing it with \x3c
@wdes-bot
Copy link
Author

Replaces #51

@williamdes williamdes mentioned this pull request Jul 21, 2020
@williamdes
Copy link

My bot @wdes-bot holds this PR for @code-lts

@anirudhchronus
Copy link

@williamdes what about ie11 support?

@williamdes
Copy link

@williamdes what about ie11 support?

Is it not working?

This is too much a long time ago, I forgot about the code of this package

@anirudhchronus
Copy link

@williamdes I didnt check it yet, I might be doing it soon. I wanted to confirm it because the 2.0 npm page says it dropped support for IE. I was wondering whether it was Including IE-11 also as many major corporations are still using IE-11. However according to this PR which is very similar to the code change you have done, they only get rid of IE 6/7/8.

@williamdes
Copy link

@williamdes I didnt check it yet, I might be doing it soon. I wanted to confirm it because the 2.0 npm page says it dropped support for IE. I was wondering whether it was Including IE-11 also as many major corporations are still using IE-11. However according to this PR which is very similar to the code change you have done, they only get rid of IE 6/7/8.

Yes, 2.0 has no more IE support.
But maybe the code still works for your IE version
Anyway you can use an older version of the package: https://www.npmjs.com/package/jquery-hashchange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants