Use bips for slippage #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
force-pushed
the
add-partner-fee
branch
from
e5fbb8f to
5c027da
Compare
anxolin
force-pushed
the
use-bips-for-slippage
branch
from
0918fe4 to
3bb0432
Compare
anxolin
force-pushed
the
use-bips-for-slippage
branch
from
0d13cb8 to
1255e24
Compare
|
@MartinquaXD @olgafetisova i just tagged you in case this breaking changes affects you |
|
The backend does not parse this field so this will not cause problems on our end. 👌 |
9 tasks
alfetopito
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation on #53
It makes use of the new
bipdefinition to redefine the quote.This is a breaking change for the metadata
quote, so I bumped the version of the schema and the metadata to a new major versionv1.0.0Basically, we want to make it contain an integer instead of a string.
quote: { slippageBips: "50" }will become:
quote: { slippageBips: 50 }I also added tests for these changes.