feat: trading API #98
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
…rading-sdk # Conflicts: # apps/twap/src/app/utils/getApiBaseUrl.ts # apps/twap/src/app/utils/getConditionalOrderId.ts # libs/repositories/src/const.ts # libs/repositories/src/datasources/viem.ts # package.json # yarn.lock
There was a problem hiding this comment.
I don't feel too strong, cause I also don't like my suggestions for the naming, but I tried to get rid of verbs and use a more RESTful naming convention
In our case it sucks a bit we need to use POST for methods that would feel more semantic with GET, but we are limited by the parameters we can pass, so I added the -request suffix to some of them. As I said, I don't love my proposal either, maybe someone else or chat gpt can give you better inspiration.
Anyways, the relevant part of this PR is APPROVEd. I just feel this API would be extremely useful for 3rd parties. It just makes integration 10x easier!
POST /trading/quote-requests - Request a new quote for placing an order
POST /trading/sell-native-currency-requests - returns a transaction details for selling native currency
POST /trading/orders - send an order to the order-book
| appDataInfo | ||
| }) | ||
|
|
||
| // ACTION NEEDED: Send <preSignTransaction> from smart-contract wallet |
There was a problem hiding this comment.
Why not adding the code to send the TX onhcain?
There was a problem hiding this comment.
It very depends on a smart-contract wallet implementation.
With Safe it requires a lot of code here.
There was a problem hiding this comment.
For Safe you can go to Transaction build and put the tx data there
README https://github.com/cowprotocol/bff/blob/feat/trading-sdk/apps/api/src/app/routes/trading/README.md
/tradingAPI provides a convenient way to use CoW Protocol.Essencially this API is a facade on top of cowprotocol/cow-sdk#213.