chore: bump pragma #155
Merged
chore: bump pragma #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfw78
added
infra
fedgiac
previously approved these changes
Jun 4, 2024
Co-authored-by: Federico Giacon <[email protected]>
fedgiac
approved these changes
Jun 4, 2024
fleupold
approved these changes
Jun 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the pragma to support up-to-and-including solidity (
0.8.26). This allows the foundry migration taking place to have tests written in solc0.8.x, reducing redundancy / effort with writing the associated test contracts.It is important that the
bytecodegenerated for production still be compliant with0.7.6(save for potential issues associated with themetadatahash appended bysolc). To facilitate this, thetestpipeline uses a multi-version matrix strategy to ensure that the contracts remain able to be built with0.7.6.A minor miscellaneous patch is also included for VS Code's solidity configuration, reducing configuration size.
Test Plan
testCI/CD runs0.7.6and0.8.26matrices.ciCI/CD runs (hardhat) and completes successfully.Related Issues
Related: #106