chore: rewrite transferOwnership script to use Foundry #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfw78
reviewed
Jun 6, 2024
mfw78
reviewed
Jun 7, 2024
mfw78
approved these changes
Jun 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The transferOwnership script has been ported to Foundry, with feature parity, including tests.
There was the need for a few workarounds in the tests, mostly because
prankandbroadcastaren't compatible with each other and because our proxy is based on Solidity 0.7 and its code isn't directly available in this repo.Test Plan
New tests.
I also deployed a new set of contracts on Sepolia and used the script to change the owner and manager. You can see the two resulting transactions for the manager and the owner.
Related Issues
Closes #102
Closes #103