Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove env #231

Merged
merged 1 commit into from
Oct 9, 2024
Merged

chore: remove env #231

merged 1 commit into from
Oct 9, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Oct 8, 2024

Description

This PR addresses the environment setup that was used for fork tests. Now, the FORK_URL is set by a secret, and the FORK_BLOCK_NUMBER is hard coded within the e2e Helper as a constant so that assumptions are visible for auditors / developers.

Test Plan

  1. Confirm CI/CD green

Related Issues

N/A

@mfw78 mfw78 requested a review from fedgiac October 8, 2024 12:11
@mfw78 mfw78 requested a review from a team as a code owner October 8, 2024 12:11
@mfw78 mfw78 merged commit 1cbd0de into e2e-migration Oct 9, 2024
8 checks passed
@mfw78 mfw78 deleted the mfw78-patch-1 branch October 9, 2024 03:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants