-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: github repository configuration #91
Conversation
Pull Request Test Coverage Report for Build 9323787344Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some content on the new workflow, the rest looks good.
.github/workflows/review-check.yml
Outdated
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other actions in this repo use checkout@v3. I don't know the difference between the two, but for consistency it makes sense to keep v3 here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped all to latest.
Co-authored-by: Federico Giacon <[email protected]>
Description
This PR:
docker
related configurationCODEOWNERS
and review check policy, enforcing thatCODEOWNERS
must review PRs, as well as enforcing a check for 2 or more reviews withinsrc/
Test Plan
src/
checking minimum review requirements.