Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github repository configuration #91

Merged
merged 18 commits into from
Jun 3, 2024
Merged

chore: github repository configuration #91

merged 18 commits into from
Jun 3, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented May 31, 2024

Description

This PR:

  • Removes all docker related configuration
  • Removes repository configurations for mergify and dependabot
  • Configures a CODEOWNERS and review check policy, enforcing that CODEOWNERS must review PRs, as well as enforcing a check for 2 or more reviews within src/
  • Minor typographical modifications to the pull request template

Test Plan

  1. CI/CD.
  2. Test PR into src/ checking minimum review requirements.

@mfw78 mfw78 added the E:5.1 Standardise contracts repository See https://github.com/cowprotocol/pm/issues/31 for details label May 31, 2024
@mfw78 mfw78 requested a review from fedgiac May 31, 2024 13:45
@mfw78 mfw78 self-assigned this May 31, 2024
@coveralls
Copy link

coveralls commented May 31, 2024

Pull Request Test Coverage Report for Build 9323787344

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%

Totals Coverage Status
Change from base Build 8895014647: 0.0%
Covered Lines: 364
Relevant Lines: 366

💛 - Coveralls

Copy link
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some content on the new workflow, the rest looks good.


steps:
- name: Checkout code
uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other actions in this repo use checkout@v3. I don't know the difference between the two, but for consistency it makes sense to keep v3 here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped all to latest.

.github/workflows/review-check.yml Outdated Show resolved Hide resolved
.github/workflows/review-check.yml Outdated Show resolved Hide resolved
.github/workflows/review-check.yml Outdated Show resolved Hide resolved
.github/workflows/review-check.yml Show resolved Hide resolved
Co-authored-by: Federico Giacon <[email protected]>
@mfw78 mfw78 merged commit bb1e137 into main Jun 3, 2024
5 checks passed
@mfw78 mfw78 deleted the github-config branch June 3, 2024 09:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E:5.1 Standardise contracts repository See https://github.com/cowprotocol/pm/issues/31 for details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants