fix: uploading appData too late (#4667)

We were trying to decode the TWAP transactions that our users were
doing. It turned out our decoding was working for some, but not for
other txs. To present a good decoding of the TWAP transaction we need
the appData as it contains information for the slippage, fee etc. It
turned out that some of the txs were not having app data. This is due
to the fact that we are trying to decode the transaction before signing,
but at this point no appData was being uploaded to the server.

Moving the uploadAppData call before the call for signing the tx solves
this problem and makes sure that appData is available even before
signing.

Co-authored-by: Leandro <[email protected]>

apps/cowswap-frontend/src/modules/twap/hooks/useCreateTwapOrder.tsx

@@ -97,6 +97,9 @@ export function useCreateTwapOrder() {
         const fallbackSetupTxs = fallbackHandlerIsNotSet
           ? await extensibleFallbackSetupTxs(extensibleFallbackContext)
           : []
+
+        // upload the app data here, as application might need it to decode the order info before it is being signed
+        uploadAppData({ chainId, orderId, appData: appDataInfo })
         const createOrderTxs = createTwapOrderTxs(twapOrder, paramsStruct, twapOrderCreationContext)
         const { safeTxHash } = await safeAppsSdk.txs.send({ txs: [...fallbackSetupTxs, ...createOrderTxs] })
 
@@ -128,7 +131,6 @@ export function useCreateTwapOrder() {
 
         orderAnalytics('Posted', orderType, 'Presign')
 
-        uploadAppData({ chainId, orderId, appData: appDataInfo })
         updateAdvancedOrdersState({ recipient: null, recipientAddress: null })
         tradeConfirmActions.onSuccess(safeTxHash)
         tradeFlowAnalytics.sign(twapFlowAnalyticsContext)