New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation may run for a permit pre-hook #5185

Closed

elena-zh opened this issue Dec 11, 2024 · 1 comment

Labels

Bug Hooks store

elena-zh commented Dec 11, 2024

Reported and discussed in https://cowservices.slack.com/archives/C0361CDG8GP/p1733927021330169

Go to Hooks
add post or pre hook on base (I add this custom one Create a hook: target = '0xdef1ca1fb7fbcdc777520aa7f396b4e015f497ab', callData = '0x70a08231000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045', gasLimit = 21000)
Go back to the limit orders-swap page
refresh the page
Specify an order with a permittable token
Go to the Confirm modal --> you will see failed simulation result

ER: simulation should not run on Swap/Limit orders pages

elena-zh added Bug Hooks store labels

elena-zh mentioned this issue

feat(swap): partial approve #5256

Open

3 tasks

Author

elena-zh commented Dec 26, 2024

Closing the issue as hooks data has been removed from the confirm modal in #5256

elena-zh closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment