feat(swap): partial approve #5256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
force-pushed
the
feat/partial-approve
branch
from
0d0fe07 to
a017d48
Compare
|
The build has failed :( |
elena-zh
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Hey @shoom3301 , great job!
I'm approving the PR.
Please don't forget to discuss with the team the 1st case reported in #5256 (comment)
And just FYI: I'm still facing issues with orders execution (1, 2, 3) on Gnosis chain (only). However, it might be related to a poor competition that we have on staging. I will retest this on Prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many users are asking for partial approve in swap because it might be dengerous to give an "infinite" approval amount.
Now we have an option in Swap settings which enables the partial approve feature.
When the option is on, then we will make an approval only for selling amount.
Important! When order is a buy order, then approval amount should be sell amount including all costs (fees, slippage, etc.).
Important! The option works only in Swap. I know, we have approvals in limit orders, tokens page, etc. But for now the feature is availabe only in Swap because it's not clear how it will affect other flows.
To Test