Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet-connect): update web3-react/walletconnect-v2 #2955

Closed
wants to merge 1 commit into from

Conversation

nenadV91
Copy link
Contributor

Summary

Updates web3-react/walletconnect-v2 package version

@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview Jul 28, 2023 10:51am

@nenadV91 nenadV91 requested review from a team July 28, 2023 10:51
@nenadV91 nenadV91 added the Wallets Wallet related label Jul 28, 2023
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@web3-react/walletconnect-v2 8.3.6...8.3.7 None +12/-12 13.7 MB zzmp

@elena-zh
Copy link
Contributor

Hey @nenadV91 , I'm done with tests.
And here are my results:

  1. I updated a list of issues in the Issues related to WCv2 (not from our side) #2744 task (removed some and added new ones)
  2. Impossible to scroll the list in WCv2 modal in iOS #2747 issue (looks like from our side) is still reproducible
  3. as well as No icon on the waiting modals when connect to MM using WCv2 #2742 issue (on our side)
  4. All the rest issues related to Safe wallet (can't understand on which side they are):
  • Wrap/Unwrap/Approve TXs hang in the pending state, view details link navigates to 404 page
  • also, there is no 'safe block' with signers info when TX is running
  • It is possible to place an order, but there is no response from the Safe when a TX is signed. Hence, the waiting modal hangs forever, and order does not appear in the activity modal
    no txs
    signed and executed order

Thanks!

@shoom3301
Copy link
Collaborator

Fixed here: #3047

@shoom3301 shoom3301 closed this Aug 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
@alfetopito alfetopito deleted the fix/update-wc branch August 15, 2023 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Wallets Wallet related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants