Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify envs, cleanup them and improve readme #3276

Closed
wants to merge 11 commits into from
Closed

feat: simplify envs, cleanup them and improve readme #3276

wants to merge 11 commits into from

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Oct 26, 2023 •
edited
Loading

Summary

This PR is a follow up on #3187 (comment)

Additionally

Prepare for multi-app mono repo setup

This PR prepares for deploying multiple Apps with the same mono-repo

image

Now each app will build into its own dir:
image

Config and Docs improvements

Tests

setupTests.ts has been promoted from cowswap-frontend specific to general monorepo root. Now all jest configs use it. This is used also to setup the .env same file for all projects. This solves a duplication we had (we had to duplicate our .env for different projects.

https://github.com/cowprotocol/cowswap/pull/3276/files#diff-a1c786cdea90125d840669112d499d337a658bf6431a8c972a2e14301d908662R6

Readme

image

Test

Run locally. You can delete you .env.local and it should run out of the box

Read the README:
https://github.com/cowprotocol/cowswap/tree/simplify-envs-and-readme

@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 5:01pm
cowswap 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 5:01pm
swap-dev ✅ Ready (Inspect) Visit Preview

🌃 Cosmos ↗︎

@socket-security
Copy link

socket-security bot commented Oct 26, 2023 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @amplitude/[email protected], [email protected]

anxolin
anxolin commented Oct 26, 2023
View reviewed changes
apps/cowswap-frontend/src/legacy/state/application/initialState.ts
// warning: localWarning,
// },
// })
// }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just coment out to bring it back if necessary. We just don't need to upload to IPFS anymore, but is a pity to delete this.

HAppy to kill it if reviewers desire so

@anxolin anxolin requested a review from a team October 26, 2023 12:43
@anxolin anxolin force-pushed the simplify-envs-and-readme branch from 0bcf332 to 0cf778a Compare October 26, 2023 12:57
@anxolin anxolin marked this pull request as ready for review October 26, 2023 13:02
alfetopito
alfetopito reviewed Oct 27, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ipfs.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
libs/common-const/src/networks.ts Show resolved Hide resolved
libs/common-const/src/networks.ts Outdated Show resolved Hide resolved
@anxolin anxolin mentioned this pull request Oct 27, 2023
Merged
@anxolin anxolin force-pushed the simplify-envs-and-readme branch from 0cf778a to 4b4d46e Compare October 27, 2023 16:49
@anxolin anxolin requested review from alfetopito and a team October 27, 2023 17:25
anxolin and others added 5 commits October 27, 2023 18:37
@anxolin
feat: simplify envs, cleanup them and improve readme
c742343
@anxolin
docs: improve links section
57084ac
@anxolin @fleupold
docs: improve readme and add REACT_APP_ORDER_BOOK_URLS (#3173)
a5f830e 
* docs: improve readme and add REACT_APP_ORDER_BOOK_URLS

* docs: improve documentation

Co-authored-by: Felix Leupold <[email protected]>

* docs: improve ini

* docs: fix name

* docs: simplify

---------

Co-authored-by: Felix Leupold <[email protected]>
@anxolin
chore: delete amplitude and a bunch of unneded envs
6e2cc4f
@anxolin
fix: fix issue with env name in error
0fc25a1
@anxolin anxolin force-pushed the simplify-envs-and-readme branch from f6240cc to 0fc25a1 Compare October 27, 2023 17:38
shoom3301
shoom3301 reviewed Oct 30, 2023
View reviewed changes
libs/common-utils/.env
@@ -1,96 +0,0 @@
# PRICE ESTIMATION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was used only for unit-tests. Probably we just should mock .env somehow

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw only later! I fixed it by using the sam .env for all projects. Now they all share the jest setup

@anxolin anxolin marked this pull request as draft October 30, 2023 16:37
@anxolin anxolin closed this Oct 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
@anxolin
Copy link
Contributor Author

anxolin commented Oct 30, 2023

Closing to test re-opening it to generate the PREVIEWS

@anxolin
Copy link
Contributor Author

anxolin commented Oct 30, 2023

I will continue here #3301

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 left review comments

@alfetopito alfetopito Awaiting requested review from alfetopito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anxolin @alfetopito @shoom3301