feat(limit-orders): allow partner fee (variant B) #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/limit-orders-partner-fee
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
approved these changes
Jun 5, 2024
alfetopito
approved these changes
Jun 5, 2024
apps/cowswap-frontend/src/modules/ordersTable/pure/ReceiptModal/index.tsx
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetForm.tsx
Show resolved
Hide resolved
… feat/limit-orders-partner-fee
… feat/limit-orders-partner-fee
… feat/limit-orders-partner-fee # Conflicts: # apps/cowswap-frontend/src/modules/trade/index.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Specification: https://www.figma.com/design/OOPIbTemw8FS2jcGWRF87x/Limit-order-fee-options?node-id=0-1
This was an initial version of limit orders with partner fee, but after some discussion we decided to switch to variant A (see the specification).
I kept this PR because it contains some valuable refactoring, anyway, main changes are done in variant A.
Please ignore any changes in
modules/limit-ordersbecause they are reverted in variant A.Refactoring
ReceiveAmountInfoand moved the interface totrademodule (commit1 commit2)TradeRatescomponent props (commit)RowFeecomponent (commit)The only valuable functional changes
getOrderAmountsWithPartnerFee()- this order takes partner fee into account for order amounts and the result is used inexecutes atprice calculation (commit)To Test
See #4502