Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve message for wrong prefix on networks #4468

Merged
merged 8 commits into from
May 22, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented May 22, 2024

Summary

Follow up on @elena-zh 's comments on #4418 from @compojoom

I made some small changes on the message.

Before:
image

After:
image

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos 🔄 Building (Inspect) Visit Preview May 22, 2024 4:20pm
cowfi 🔄 Building (Inspect) Visit Preview May 22, 2024 4:20pm
explorer-dev 🔄 Building (Inspect) Visit Preview May 22, 2024 4:20pm
swap-dev ✅ Ready (Inspect) Visit Preview May 22, 2024 4:20pm
widget-configurator 🔄 Building (Inspect) Visit Preview May 22, 2024 4:20pm

@anxolin anxolin requested review from MartinquaXD and a team and removed request for MartinquaXD May 22, 2024 15:08
@elena-zh
Copy link
Contributor

Hey @anxolin , thank you!!
Some nitpicks from my side: could you please remove Ethereum from the brackets as it duplicates the message below, and maybe add a border-radius to the chain container? I've added 8px

image

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @anxolin !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants