Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hooks-store): new design & refactoring #4859

Merged
merged 34 commits into from
Sep 11, 2024

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Sep 4, 2024

Summary

Design: https://www.figma.com/design/1ctikx9sFa9Ff925GRsjvC/Hook-Store

Changes:

  1. Separated pure/container components
  2. Simplified HookDappContext: now it is passed as a component prop instead of react context
  3. Added localStorage persisting for hooks state
  4. Added hooks editing
  5. And of course, applied the new design from Michel's PR
-- -- -- -- --
image image image image image

To Test

Please, keep in mind that the feature is not ready yet and still under feature-flag.

  1. UI should corrsepond to the Figma layouts. (reordering feature is not implemented yet)
  2. Added hooks should be saved in localStorage (should be applied to the form after page refresh)
  3. "Build your own" hook should be editable

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Sep 11, 2024 9:39am
cowfi ✅ Ready (Inspect) Visit Preview Sep 11, 2024 9:39am
explorer-dev ✅ Ready (Inspect) Visit Preview Sep 11, 2024 9:39am
swap-dev ✅ Ready (Inspect) Visit Preview Sep 11, 2024 9:39am
widget-configurator 🛑 Canceled (Inspect) Sep 11, 2024 9:39am

Base automatically changed from eslint-update to develop September 4, 2024 10:42
Copy link

socket-security bot commented Sep 11, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Protestware/Troll package npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

Report too large to display inline

View full report↗︎

@elena-zh
Copy link

@elena-zh it's a bit complicated for now, let's keep it as it is (hooks are always disabled for eth-flow)

added this case into #4662

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shoom3301, there are several UI and low priority issues, but I will open a separate task to address them.
But I'd like to mention one issue that I'm concerned about:

  1. Place an order with a permittable token (not approved) through Hooks form
  2. While this order is Open, go to the swap page and place an order with the same token pair.

AR: there are 2 possible outcomes:

  1. The app requires me to sign a permit request once again
  2. The app does not allow me to place the order due to 'insufficient allowance' error
  3. in both cases I see error fetching permit data on console.

permit
куйгшкуы

Could you please double check this case and LMK whether this should be addressed in the current PR or in the another task?
Thanks

@shoom3301
Copy link
Collaborator Author

@elena-zh thanks! Please put it in a new task, we will take care of it later

@elena-zh
Copy link

elena-zh commented Sep 11, 2024

@elena-zh thanks! Please put it in a new task, we will take care of it later

Now reported here: #4727
Hooks are not added to the AppData when connected to a SC wallet: #4874
All the rest issues can be found in #4662

@shoom3301 shoom3301 merged commit 1b989fa into develop Sep 11, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the feat/hooks-store-reiteration-1 branch September 11, 2024 12:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants