-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hooks-store): new design & refactoring #4859
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… feat/hooks-store-reiteration-1
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is protestware?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package may come along with functionality unrelated to its primary purpose. What is a critical CVE?Contains a Critical Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Report too large to display inline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shoom3301, there are several UI and low priority issues, but I will open a separate task to address them.
But I'd like to mention one issue that I'm concerned about:
- Place an order with a permittable token (not approved) through Hooks form
- While this order is Open, go to the swap page and place an order with the same token pair.
AR: there are 2 possible outcomes:
- The app requires me to sign a permit request once again
- The app does not allow me to place the order due to 'insufficient allowance' error
- in both cases I see error fetching permit data on console.
Could you please double check this case and LMK whether this should be addressed in the current PR or in the another task?
Thanks
@elena-zh thanks! Please put it in a new task, we will take care of it later |
Summary
Design: https://www.figma.com/design/1ctikx9sFa9Ff925GRsjvC/Hook-Store
Changes:
HookDappContext
: now it is passed as a component prop instead of react contextTo Test
Please, keep in mind that the feature is not ready yet and still under feature-flag.