-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release drag drop styling #4893
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
The library also supports multi select/drag: https://sortablejs.github.io/Sortable/#multi-drag But keeping it out of scope for this one |
Hey @fairlighteth , the build has been cancelled. Was it done intentionally? If no, could you please retrigger it? |
…to release-drag-drop
@elena-zh build fixed now! |
@fairlighteth it looks amazing now! |
@shoom3301 will be addressed in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fairlighteth , great, thank you for improving this!
I'm approving the PR, however, I should let you know that there are still some style related issues reported in #4662:
-
2. It would be great to add simple FE validation into the fields on the Add hook fields (plus enhance the UI of these fields)
-
5. it would be great to change colors for fields in the dark mode
-
6. No bottom border radius for a hook description in a mobile view. Overall, it would be great to improve responsive views
-
7. arrow to go back from a hook details is not clickable in a mobile view
-
8. when I start typing into a custom hooks field, the app is auto-focused in a mobile device
It would be great if you take a look at them :)
Summary
Screen.Recording.2024-09-16.at.16.12.10.mov