Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release drag drop styling #4893

Merged
merged 10 commits into from
Sep 17, 2024
Merged

feat: release drag drop styling #4893

merged 10 commits into from
Sep 17, 2024

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Sep 13, 2024

Summary

  • Replaces drag and drop to have a touch supporting drag and drop library
  • General styling
  • Introduce numbering
Screen.Recording.2024-09-16.at.16.12.10.mov

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Sep 17, 2024 9:25am
cowfi ✅ Ready (Inspect) Visit Preview Sep 17, 2024 9:25am
explorer-dev ✅ Ready (Inspect) Visit Preview Sep 17, 2024 9:25am
swap-dev ✅ Ready (Inspect) Visit Preview Sep 17, 2024 9:25am
widget-configurator ✅ Ready (Inspect) Visit Preview Sep 17, 2024 9:25am

Copy link

socket-security bot commented Sep 16, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@fairlighteth fairlighteth marked this pull request as ready for review September 16, 2024 15:15
@fairlighteth fairlighteth requested review from a team September 16, 2024 15:15
@fairlighteth
Copy link
Contributor Author

The library also supports multi select/drag: https://sortablejs.github.io/Sortable/#multi-drag

But keeping it out of scope for this one

@elena-zh
Copy link

Hey @fairlighteth , the build has been cancelled. Was it done intentionally? If no, could you please retrigger it?

@fairlighteth
Copy link
Contributor Author

@elena-zh build fixed now!

@shoom3301
Copy link
Collaborator

@fairlighteth it looks amazing now!
Btw, I see Tenderly simulation block is missing. Are you going to redesign it in this PR?

@fairlighteth
Copy link
Contributor Author

@shoom3301 will be addressed in a separate PR

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fairlighteth , great, thank you for improving this!

I'm approving the PR, however, I should let you know that there are still some style related issues reported in #4662:

  • 2. It would be great to add simple FE validation into the fields on the Add hook fields (plus enhance the UI of these fields)

  • 5. it would be great to change colors for fields in the dark mode
    image

  • 6. No bottom border radius for a hook description in a mobile view. Overall, it would be great to improve responsive views
    image

  • 7. arrow to go back from a hook details is not clickable in a mobile view
    image

  • 8. when I start typing into a custom hooks field, the app is auto-focused in a mobile device
    image
    image

  • 9. General UI issues in a mobile view:
    image
    image

It would be great if you take a look at them :)

@shoom3301 shoom3301 merged commit 9d72b77 into develop Sep 17, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the release-drag-drop branch September 17, 2024 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants