feat(hooks-store): add dapp id to hook callData #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/hooks-iframe-app # Conflicts: # apps/cowswap-frontend/src/modules/hooksStore/hooks/usePostHooksRecipientOverride.ts # apps/cowswap-frontend/src/modules/hooksStore/hooks/useSetRecipientOverride.ts # apps/cowswap-frontend/src/modules/hooksStore/types/hooks.ts # apps/cowswap-frontend/src/modules/trade/hooks/useResetRecipient.ts
…l/cowswap into feat/hooks-iframe-app-1
…col/cowswap into feat/hooks-iframe-app-2
…col/cowswap into feat/hooks-iframe-app-3
…col/cowswap into feat/hooks-iframe-app-4
…col/cowswap into feat/hooks-iframe-app-5
…col/cowswap into feat/hooks-iframe-app-6
…col/cowswap into feat/hooks-iframe-app-7
…col/cowswap into feat/hooks-iframe-app-8
… feat/hooks-iframe-app
…l/cowswap into feat/hooks-iframe-app-1 # Conflicts: # apps/cowswap-frontend/src/modules/trade/hooks/useNotifyWidgetTrade.ts
…col/cowswap into feat/hooks-iframe-app-3
…col/cowswap into feat/hooks-iframe-app-4
…col/cowswap into feat/hooks-iframe-app-6
…col/cowswap into feat/hooks-iframe-app-8
Co-authored-by: Leandro <[email protected]>
… feat/hook-to-dapp-matching # Conflicts: # apps/cowswap-frontend/src/modules/hooksStore/containers/HookRegistryList/index.tsx # apps/cowswap-frontend/src/modules/hooksStore/hookRegistry.tsx # apps/cowswap-frontend/src/modules/hooksStore/hooks/useAddHook.ts # apps/cowswap-frontend/src/modules/hooksStore/hooks/useAllHookDapps.ts # apps/cowswap-frontend/src/modules/hooksStore/pure/AddCustomHookForm/CustomDappLoader/index.tsx # apps/cowswap-frontend/src/modules/hooksStore/pure/HookDappDetails/index.tsx # apps/cowswap-frontend/src/modules/hooksStore/state/customHookDappsAtom.ts # apps/cowswap-frontend/src/modules/hooksStore/types/hooks.ts # apps/cowswap-frontend/src/modules/hooksStore/utils.ts # apps/hook-dapp-omnibridge/public/manifest.json # libs/hook-dapp-lib/src/types.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
shoom3301
changed the title
alfetopito
approved these changes
Oct 2, 2024
apps/cowswap-frontend/src/modules/hooksStore/hooks/useInternalHookDapps.ts
Outdated
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/hooksStore/pure/AddCustomHookForm/CustomDappLoader/index.tsx
Show resolved
Hide resolved
… feat/hook-to-dapp-matching
|
Report too large to display inline |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In different places we need a way to display an order hook details (at least a dapp which is created the hook).
To do that we first of all need a registry with all known hook-dapps, here is it (hookDappsRegistry.json).
I also added
idfield to each hook-dapp in order to use it for matching hooks with their dapps.In this PR the hook-dapp id is appended to the hook callData, but we decided to allocated a separate field in the hook data (PR). This will be applied in another PR on top of this.
To Test
No need to test (please test all recent changes all together when design for hook details is ready)