-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(smart-slippage): update smart slippage text #4982
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @alfetopito , great! Some notes:
Thanks! |
@alfetopito there are several TODOs in |
Fixed
Fixed
I tried but failed to fix the CSS issue :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfetopito , thanks! I've opened #4985 for @fairlighteth to address this issue.
Summary
Follow up to #4934, addressing these comments #4934 (comment) from @MindyCoW
Additionally, makes sure the
High slippage amount selected
in the settings tab is only displayed if user picks a value above the suggested slippage - if any. Otherwise sticks to the default of 1%.To Test
High slippage amount selected
High slippage amount selected