Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yield): use lp-token in widget #5013

Merged
merged 100 commits into from
Oct 29, 2024
Merged

Conversation

shoom3301
Copy link
Collaborator

Summary

  1. Added pool info displaying (click on info icon)
  2. Bound lp-tokens to yield widget (now you can select it and potentially trade)
  3. Generalized lp-token logo displaying
  4. Bound search input to lp-token list
image image

To Test

  1. You should be able to select lp-token in Yield widget
  2. If there is more than one lp-token with the same symbol, then token address should be used in URL
  3. Pool page should be displayed (design is not finished yet! UI input from @fairlighteth)
  4. APR should be displayed in token selector only for AAVE/WETH token (hardcoded)

ZeroApprovalWarning and HighFeeWarning
… feat/vampire-attack-lp-tokens

# Conflicts:
#	apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetForm.tsx
#	apps/cowswap-frontend/src/modules/trade/containers/TradeWidgetLinks/styled.ts
…wprotocol/cowswap into feat/vampire-attack-pools-info

# Conflicts:
#	apps/cowswap-frontend/src/modules/tokensList/containers/LpTokenListsWidget/index.tsx
#	apps/cowswap-frontend/src/modules/tokensList/pure/LpTokenLists/index.tsx
#	apps/cowswap-frontend/src/modules/tokensList/pure/LpTokenLists/styled.ts
@shoom3301
Copy link
Collaborator Author

@elena-zh thanks!
Fixed 2nd as well

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Base automatically changed from feat/vampire-attack-lp-tokens to develop October 29, 2024 08:30
… feat/vampire-attack-pools-info

# Conflicts:
#	apps/cowswap-frontend/src/common/updaters/LpBalancesAndAllowancesUpdater.tsx
#	apps/cowswap-frontend/src/modules/application/containers/App/Updaters.tsx
#	apps/cowswap-frontend/src/modules/tokensList/containers/LpTokenListsWidget/index.tsx
#	apps/cowswap-frontend/src/modules/tokensList/containers/SelectTokenWidget/index.tsx
#	apps/cowswap-frontend/src/modules/tokensList/pure/LpTokenLists/index.tsx
#	apps/cowswap-frontend/src/modules/tokensList/pure/LpTokenLists/styled.ts
#	apps/cowswap-frontend/src/modules/tokensList/pure/SelectTokenModal/index.tsx
#	libs/balances-and-allowances/src/updaters/BalancesAndAllowancesUpdater.tsx
#	libs/tokens/src/const/tokensLists.ts
#	libs/tokens/src/types.ts
</LpTokenWrapper>
</TokenLogoWrapper>
)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool!!!! so we use the same component that you tough it to represent pools!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants