fix(hooks-store): disable selling eth #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elena-zh
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Hey @shoom3301 , great job!
But there is 1 nitpick: could you please remove this 'bundling' banner from the Hooks tab when pick 'ETH' to sell inside the Safe?
|
@elena-zh thanks! FIxed |
|
Hey @shoom3301 , I still can see the bundling banner when a quote is being loaded: https://www.loom.com/share/98025041342e4e2cac3f03edc0606104 Might it be possible to remove it completely? Thanks |
|
@elena-zh fixed |
anxolin
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4662 (case 2)
Selling ETH doesn't work well with hooks, so we decided to disable it (similarly to limit orders).
To Test
See #4662 (case 2)