Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add winter theme 🎅 #5213

Merged
merged 8 commits into from
Dec 17, 2024
Merged

feat: add winter theme 🎅 #5213

merged 8 commits into from
Dec 17, 2024

Conversation

fairlighteth
Copy link
Contributor

Summary

Adds a new winter theme to CoW Swap:

  • Requires featureFlags.isChristmasEnabled
  • Adjust success sound
  • Adds Snow
  • Winter theme dark/light mode logo and background images (desktop/medium/small)
Screen.Recording.2024-12-16.at.16.19.46.mov
Screen.Recording.2024-12-16.at.16.19.19.mov

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 17, 2024 1:10pm
cowfi 🔄 Building (Inspect) Visit Preview Dec 17, 2024 1:10pm
explorer-dev 🔄 Building (Inspect) Visit Preview Dec 17, 2024 1:10pm
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 17, 2024 1:10pm
swap-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 1:10pm
widget-configurator 🔄 Building (Inspect) Visit Preview Dec 17, 2024 1:10pm

@fairlighteth fairlighteth requested review from a team December 16, 2024 16:36
@socket-security Socket Security
Copy link

socket-security bot commented Dec 16, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

shoom3301
shoom3301 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@shoom3301 shoom3301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks amazing!

@shoom3301 shoom3301 changed the title 🎅 Add winter theme feat: add winter theme 🎅 Dec 17, 2024
elena-zh
elena-zh reviewed Dec 17, 2024
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fairlighteth ,
great job!

Some issues:

  1. on the 1st app opening, I can see this huge logo (both in a mobile device and in a desktop version)
    image
  2. On a Traded (success event) I hear a regular sound. Is this expected?
    Thanks!

@anxolin anxolin added the RELEASE Included in the release that is being closed label Dec 17, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Dec 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 15.6 kB nicolo-ribaudo
npm/[email protected] None 0 4.05 kB qix

View full report↗︎

@anxolin
Copy link
Contributor

anxolin commented Dec 17, 2024

on the 1st app opening, I can see this huge logo (both in a mobile device and in a desktop version)

@elena-zh i can't reproduce that one. I tried in IOS device and incognito mode and doesn't happen to me. I even tried to throttle the internet speed, and it works fine to me

On a Traded (success event) I hear a regular sound. Is this expected?

I added a new sound

@anxolin anxolin requested a review from elena-zh December 17, 2024 12:18
@elena-zh
Copy link

mode and doesn't happen to me. I even tried to throttle the internet speed, and it works fine to me
Cool then! Because it may happen to me in incognito mode when I open the app there for the 1st time (reproducible in Chrome browser).
image

The sound is great, thank you for adding it!

@anxolin anxolin enabled auto-merge (squash) December 17, 2024 13:03
@anxolin anxolin merged commit 7db4b72 into develop Dec 17, 2024
9 of 13 checks passed
@anxolin anxolin deleted the winter-theme-2024 branch December 17, 2024 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@elena-zh elena-zh elena-zh approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees
No one assigned
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairlighteth @anxolin @elena-zh @shoom3301