Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(wallets): add metaMask SDK connector (#5028)" #5215

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Revert "feat(wallets): add metaMask SDK connector (#5028)" #5215

merged 1 commit into from
Dec 17, 2024

Conversation

shoom3301
Copy link
Collaborator

This reverts commit fe8f376.

#5028 - this change had broken the Metamask in mobile

@shoom3301 shoom3301 requested review from a team December 17, 2024 10:10
@shoom3301 shoom3301 self-assigned this Dec 17, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:23am
cowfi ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:23am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:23am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:23am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:23am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:23am

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 20 kB nicolo-ribaudo
npm/[email protected] None 0 9.04 kB qix
npm/[email protected] None 0 10.4 kB isaacs
npm/[email protected] None 0 5.39 kB eventualbuddha
npm/[email protected] None 0 7.39 kB sindresorhus
npm/[email protected] None 0 4.51 kB jbgutierrez
npm/[email protected] None 0 9.18 kB ljharb

View full report↗︎

@anxolin anxolin added the RELEASE Included in the release that is being closed label Dec 17, 2024
@shoom3301 shoom3301 merged commit 889b78e into develop Dec 17, 2024
12 of 13 checks passed
@shoom3301 shoom3301 deleted the revert/metamask-connector branch December 17, 2024 10:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoom3301 @anxolin