Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for a bad CMS request #5221

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: account for a bad CMS request #5221

merged 1 commit into from
Dec 17, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 17, 2024

Summary

If the CMS calls fail, we might not know the number of solvers in a network
image

This PR accounts for that.

Test

  1. Block requests to CMS.
image
  1. Clear local storage

  2. Trade

  3. Asserts the message is still readable

image

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos 🔄 Building (Inspect) Visit Preview Dec 17, 2024 3:19pm
cowfi 🔄 Building (Inspect) Visit Preview Dec 17, 2024 3:19pm
explorer-dev 🔄 Building (Inspect) Visit Preview Dec 17, 2024 3:19pm
sdk-tools 🔄 Building (Inspect) Visit Preview Dec 17, 2024 3:19pm
swap-dev 🔄 Building (Inspect) Visit Preview Dec 17, 2024 3:19pm
widget-configurator 🔄 Building (Inspect) Visit Preview Dec 17, 2024 3:19pm

@anxolin anxolin added the RELEASE Included in the release that is being closed label Dec 17, 2024
@anxolin anxolin merged commit 8d2edd7 into main Dec 17, 2024
4 of 11 checks passed
@anxolin anxolin deleted the account-for-bad-cms branch December 17, 2024 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@vercel vercel bot temporarily deployed to Preview – cosmos December 17, 2024 15:56 Inactive
@vercel vercel bot temporarily deployed to Preview – sdk-tools December 17, 2024 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – cowfi December 17, 2024 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer-dev December 17, 2024 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – swap-dev December 17, 2024 15:58 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants