Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow any safe-like apps #5235

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: allow any safe-like apps #5235

merged 1 commit into from
Dec 19, 2024

Conversation

shoom3301
Copy link
Collaborator

Summary

Context: https://cowservices.slack.com/archives/C03DVQREAH0/p1734609531567519

This is a revert of #4931

To Test

Need to run Safe app locally and specify baseUrl to this PR preview link, so I will test it by myself

@shoom3301 shoom3301 requested review from a team December 19, 2024 12:34
@shoom3301 shoom3301 self-assigned this Dec 19, 2024
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Dec 19, 2024 0:41am
cowfi ✅ Ready (Inspect) Visit Preview Dec 19, 2024 0:41am
explorer-dev ✅ Ready (Inspect) Visit Preview Dec 19, 2024 0:41am
sdk-tools ✅ Ready (Inspect) Visit Preview Dec 19, 2024 0:41am
swap-dev ✅ Ready (Inspect) Visit Preview Dec 19, 2024 0:41am
widget-configurator ✅ Ready (Inspect) Visit Preview Dec 19, 2024 0:41am

@shoom3301 shoom3301 changed the base branch from develop to main December 19, 2024 13:13
@shoom3301 shoom3301 changed the base branch from main to develop December 19, 2024 13:13
@shoom3301 shoom3301 merged commit fc13cc4 into develop Dec 19, 2024
12 of 13 checks passed
@shoom3301 shoom3301 deleted the fix/safe-allow-domains branch December 19, 2024 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve, revertttttttt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants