fix(eth-flow): set chainId explicitly when sending ethFlow tx #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elena-zh
approved these changes
Dec 20, 2024
|
Proceeding with a hotfix release, please post merge review |
anxolin
reviewed
Dec 20, 2024
apps/cowswap-frontend/src/modules/swap/services/ethFlow/steps/signEthFlowOrderStep.ts
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/swap/services/ethFlow/steps/signEthFlowOrderStep.ts
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly sets chainId when sending EthFlow tx
Background
Despite us having already introduced some checks to try to prevent users from sending EthFlow txs to the wrong chain (#4629), it still happened again.
It can be then that somehow the wallet has a wrong network and sends the tx from the wrong one.
This change attempts to force the chain upon the wallet so that doesn't happen.
To Test