-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/limit UI upgrade 2 #5267
Open
fairlighteth
wants to merge
47
commits into
feat/limit-ui-upgrade
Choose a base branch
from
feat/limit-ui-upgrade-2
base: feat/limit-ui-upgrade
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/limit UI upgrade 2 #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fairlighteth
commented
Jan 2, 2025
•
edited
Loading
edited
- Add global USD toggle in the limit order settings menu
- Make prepend symbol ($) in input/output fields non-selectable
- Numerical input allow typing decimals at the end, smarter numbers paste trimming and allow deleting whole value (resetting to 0).
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
* feat: meditating cow bg color * feat: full amount on trimmed amounts --------- Co-authored-by: Leandro <[email protected]>
* feat: meditating cow bg color * feat: full amount on trimmed amounts * feat: keep settings menu open --------- Co-authored-by: Leandro <[email protected]>
* feat: meditating cow bg color * feat: full amount on trimmed amounts * feat: keep settings menu open * feat: twap expiration logic display * feat: cancelling and signing status styles * fix: remove unused parameter * chore: misc refactorings --------- Co-authored-by: Leandro <[email protected]>
* feat: clear order selection on change tabs * feat: twap parent order statusses * feat: twap styling and status
* feat: style twap table layouts * feat: style twap table layout
* feat: add empty cell for signing twap order * feat: twap limit table layout * feat: fix signing tab filtering
* feat: update limit table on state change * feat: table control logic unfillable
* fix: buy amount behaviour on limit orders form * chore: update lock icon tooltip * fix: lint * feat: limit price is locked by default (same as prod currently)
* feat: only show twap market price for non final states * feat: address comments children * feat: update market price logic display * feat: twap child order status logic optimisations * feat: order display logic * feat: hide orders table widget (#5303) * feat: hide orders table widget * feat: hide orders table widget for limit and twap
This is the PR used for consolitdation? |
It's what's being used as a base, but we should probably merge it into the parent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.