feat: only show twap market price for non final states #5302
+151
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
anxolin
reviewed
Jan 16, 2025
| '-' | ||
| ) : spotPrice ? ( | ||
| const renderMarketPrice = () => { | ||
| // Early return for cancelled, warning, or presignature pending states |
There was a problem hiding this comment.
nit, and not from this PR, but withWarning should be the latest or first condition, as it reads more natural, state in CANCELED, PRESIGN or has a warning
There was a problem hiding this comment.
Addressed this now
|
|
||
| // Check children finalization status | ||
| if (children) { | ||
| const childrenArray = React.Children.toArray(children) as React.ReactElement<{ order: ParsedOrder }>[] |
There was a problem hiding this comment.
I agree with react documentation
Can't we reason using just the data props instead?
There was a problem hiding this comment.
addressed this
elena-zh
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Hey @fairlighteth , great! However, still for some Expired orders I can see a market price.
Examples:
Could you please check why?
|
@elena-zh the issues should be fixed now: |
alfetopito
force-pushed
the
feat/limit-ui-upgrade-12
branch
from
1a6e5f0 to
3ad7920
Compare
Base automatically changed from
feat/limit-ui-upgrade-12
to
feat/limit-ui-upgrade-2
January 16, 2025 16:06
alfetopito
force-pushed
the
feat/limit-ui-upgrade-13
branch
from
02cbfe4 to
f449a1d
Compare
* feat: hide orders table widget * feat: hide orders table widget for limit and twap
alfetopito
approved these changes
Jan 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show market price only for active orders