Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amount locking #5304

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

alfetopito
Copy link
Collaborator

Summary

  • Fixes buy amount behaviour on limit form for locked/unlocked price
  • Sets price locking ON by default (same as prod currently)

Sell behaviour should also work as usual, as well as limit price changes.

In summary:

  • Edit sell amount:
    • Price locked (default, same as prod): update buy amount
    • Price unlocked: update price
  • Edit buy amount:
    • Price locked (default, same as prod): update sell amount
    • Price unlocked: update price
  • Edit price:
    • Price locked or unlocked: update the field opposite to the last edited one

To Test

  1. Test all 6 scenarios defined above

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos 🔄 Building (Inspect) Visit Preview Jan 16, 2025 4:25pm
cowfi 🔄 Building (Inspect) Visit Preview Jan 16, 2025 4:25pm
explorer-dev 🔄 Building (Inspect) Visit Preview Jan 16, 2025 4:25pm
sdk-tools 🔄 Building (Inspect) Visit Preview Jan 16, 2025 4:25pm
swap-dev 🔄 Building (Inspect) Visit Preview Jan 16, 2025 4:25pm
widget-configurator 🔄 Building (Inspect) Visit Preview Jan 16, 2025 4:25pm

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @alfetopito !
There is one issue that is related to the Global USD state, but it will be addressed later.

@alfetopito alfetopito force-pushed the fix/sell-amount-lock branch from c167fa3 to ba16f95 Compare January 16, 2025 16:24
@alfetopito alfetopito merged commit 4a5b08f into feat/limit-ui-upgrade-2 Jan 16, 2025
4 of 11 checks passed
@alfetopito alfetopito deleted the fix/sell-amount-lock branch January 16, 2025 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants