enhance order categorization and warning handling in OrdersTableWidget #5320
Conversation
* feat: hide orders table widget * feat: hide orders table widget for limit and twap
…col/cowswap into feat/limit-ui-upgrade-15 # Conflicts: # apps/cowswap-frontend/src/common/updaters/orders/SpotPricesUpdater.ts
…l/cowswap into feat/limit-ui-upgrade-15 # Conflicts: # apps/cowswap-frontend/src/common/updaters/orders/SpotPricesUpdater.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
| (childOrder) => | ||
| childOrder.status !== OrderStatus.FULFILLED && | ||
| (childOrder.status === OrderStatus.SCHEDULED || childOrder.status === OrderStatus.PENDING) && | ||
| (getOrderParams(chainId, balancesAndAllowances, childOrder)?.hasEnoughBalance === false || |
There was a problem hiding this comment.
getOrderParams is called twice here, should be cached to a const
There was a problem hiding this comment.
Should be addressed now.
There was a problem hiding this comment.
@fairlighteth , Thank you!
There is 1 nitpick:
- I place a TWAP order where I bundle 'Approve+Place order' transaction
- After 'Singing' state, the parent order blinks with 'Order filled' status
Could you please take a look a this issue?
…l/cowswap into feat/limit-ui-upgrade-16 # Conflicts: # apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/OrderRow/index.tsx
…ocol/cowswap into feat/limit-ui-upgrade-17
Should be fixed in this PR now. |
I could not quickly replicate this. I would propose to address this in a separate PR. |
There was a problem hiding this comment.
Thank you!
Opened https://www.notion.so/cownation/TWAP-order-blinks-with-Filled-status-when-signed-1848da5f04ca8076b845c787b9bd6ec2 task for the blink issue
refactor: enhance order categorization and warning handling in OrdersTableWidget