fix: display Metamask warning only for extension/mobile wallets #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
alfetopito
reviewed
Feb 3, 2025
...wswap-frontend/src/modules/tradeWidgetAddons/containers/MetamaskTransactionWarning/index.tsx
Outdated
Show resolved
Hide resolved
elena-zh
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Hey @shoom3301 , everything looks great besides 1 issue: there is no warning inside the MM integrated browser
|
@elena-zh fixed |
alfetopito
approved these changes
Feb 3, 2025
* feat: forward provider meta info into widget * feat: display Metamask warning in widget * chore: fix METAMASK_WALLET_NAME_REGEX * refactor: extract useWidgetProviderMetaInfo * chore: fix isRabby
anxolin
reviewed
Feb 5, 2025
| */ | ||
| function useIsMetamaskMobileInjectedWallet(): boolean { | ||
| const walletProvider = useWalletProvider() | ||
| const rawProvider = walletProvider?.provider as any |
There was a problem hiding this comment.
I think we should not make use of as, if something we could use typescript type guards
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5369
isMetamask = trueand only display it for Metamask browser extensionTo Test
See above