Update docs: /reveal endpoint removed #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
m-lord-renkse
requested review from
MartinquaXD and
sunce86
and removed request for
MartinquaXD
MartinquaXD
reviewed
Sep 11, 2024
| @@ -122,7 +119,6 @@ The scoring process is described in detail in the [description of CoW Protocol's | |||
| The autopilot selects the winner according to the highest score once the allotted time expires or all solvers have returned their batch proposal. | |||
|
|
|||
| Up to this point, the autopilot only knows the score and not the full solution that achieves that score. | |||
| The autopilot then asks the winning solver to reveal its score (through `/reveal`) and then to execute the corresponding settlement transaction (`/settle`). | |||
There was a problem hiding this comment.
Should still mention that we do a /settle call.
Good point @MartinquaXD ! do you think need to do it in this PR or in an upcoming one just for it? |
MartinquaXD
approved these changes
Sep 13, 2024
Co-authored-by: Martin Magnus <[email protected]>
|
Issue created for extending/creating section for shadow competition: #415 |
marshymarsh
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the references to
/revealendpoint, since it was removed.Fixes #2942