Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fees documentation #450

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Update fees documentation #450

merged 2 commits into from
Feb 19, 2025

Conversation

elena-zh
Copy link
Contributor

@elena-zh elena-zh commented Feb 17, 2025

Description

A list of fee-free tokens is controlled by 'Correlated tokens' collection in the CMS now. Fees are not applied for stable coins and some correlated assets lie WETH/ETH/RETH/etc.

The current PR introduces more generic description for fee-free tokens instead of listing them.

To test

Open https://docs-git-elena-zh-patch-2-cowswap.vercel.app/governance/fees
image

@elena-zh elena-zh requested a review from a team as a code owner February 17, 2025 12:16
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 18, 2025 4:38pm

Copy link

github-actions bot commented Feb 17, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@elena-zh
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@elena-zh
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Feb 17, 2025
@elena-zh elena-zh requested a review from a team February 17, 2025 12:40
>
> - **Gnosis Chain**: sDAI, xDAI, wxDAI, EURe, GBPe, USDC, USDC.e, USDT (trading these stablecoins with each other on Gnosis Chain will incur zero fee)
> - **Arbitrum One**: USDC, DAI, USDT, USDe, USDM, FRAX, MIM (trading these stablecoins with each other on Arbitrum One will incur zero fee)
> **Eligible orders:** all market orders, limit orders, and TWAPs made on Gnosis Chain and Arbitrum One, excluding tokens with correlated prices, when they are traded for each other.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **Eligible orders:** all market orders, limit orders, and TWAPs made on Gnosis Chain and Arbitrum One, excluding tokens with correlated prices, when they are traded for each other.
> **Eligible orders:** All market orders, limit orders, and TWAPs made on Gnosis Chain and Arbitrum One, excluding tokens with correlated prices when traded for each other.

Just a small nitpick to make it slightly simpler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated. I've left 'all' without changes as it corresponds to pattern used in other paragraphs.
image

@cowmarketing cowmarketing merged commit 04153f6 into main Feb 19, 2025
4 checks passed
@cowmarketing cowmarketing deleted the elena-zh-patch-2 branch February 19, 2025 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants