Extend main rewards query to all chains #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram-vdberg
approved these changes
Dec 23, 2024
| cast(cast(rbr.data.capped_payment as varchar) as int256) as capped_payment -- noqa: RF01 | ||
| from cowswap.raw_batch_rewards as rbr | ||
| select | ||
| rbr.solver as winning_solver, |
There was a problem hiding this comment.
Why don't we need to use the from_hex() and cast() methods anymore?
There was a problem hiding this comment.
For the solver, the reason we were using from_hex() was that the solver was stored as a string (and not as varbinary) in the cowswap.raw_batch_rewards table.
As for the different casts for fees, executions costs etc, i think they were just unnecessary, and an overkill. It looks like we wanted to get to an int256 but the queries also work with the decimal(38,0) type that is what we use here anyways.
Definitely this is not very well-thought through, so we could also make the raw order/batch tables return int256 instead.
harisang
added a commit
to cowprotocol/solver-rewards
that referenced
this pull request
Dec 23, 2024
This PR addresses the change proposed here: cowprotocol/dune-queries#102 that adds a blockchain parameter in the main rewards dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the main query that is used to verify the rewards to all chains.
It also slightly restructures a subfolder