Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CIP-48 query (id 4017925) #13

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix CIP-48 query (id 4017925) #13

merged 2 commits into from
Sep 5, 2024

Conversation

bram-vdberg
Copy link
Contributor

The recent changes to the CIP-48 query seem to have introduced an error. This is because the cow_protocol_ethereum.VouchRegister_evt_Vouch table uses camel case for the bondingPool and CowRewardTarget columns. This PR reverts those columns in the CIP-48 query to a naming format that is compatible with the table.

@bram-vdberg bram-vdberg requested a review from harisang September 5, 2024 09:37
@harisang harisang changed the title Fix CIP-48 query Fix CIP-48 query (id 4017925) Sep 5, 2024
@harisang
Copy link
Contributor

harisang commented Sep 5, 2024

Oh good catch, and sorry for introducing this error!

@harisang harisang merged commit 857b4de into main Sep 5, 2024
1 check passed
@harisang harisang deleted the Fix-CIP-48-Error branch September 5, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants