[Easy] Reorder payout dashboard columns #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
reviewed
Sep 17, 2024
cowprotocol/accounting/rewards/mainnet/mainnet_dashboard_query_2510345.sql
Outdated
Show resolved
Hide resolved
…_2510345.sql Co-authored-by: Felix Henneke <[email protected]>
|
A solver team said it is helpful for them to see the columns
in the main dashboard. Which i guess is reasonable as they can easily then check how much they spent, how close network fees were to actual execution costs, and what was their actual profit for the week. @fleupold Do you mind adding those back? |
harisang
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the verification of the payout transaction simpler.
Test Plan
https://dune.com/cowprotocol/cow-solver-rewards?start_time=2024-09-10+00%3A00%3A00&end_time=2024-09-17+00%3A00%3A00
