Solver dashboard #64
Solver dashboard #64
Conversation
…ameters input from dune sql in many situations
|
@PoloX2021 Could you add a brief description/documentation at the very beginning of each query? |
|
@PoloX2021 Regarding the queries that are not useful anymore. I would suggest we either delete them right away, but removing the sql code and adding a comment at the top saying "NOT RELEVANT ANYMORE" or something like that, or open an issue right away to delete them in a follow-up PR |
| @@ -0,0 +1,33 @@ | |||
| -- This query finds the number of transactions where the rewards reached the upper bound | |||
There was a problem hiding this comment.
This looks like more of an internal monitoring/special-purpose stat. Where is this query referenced?
There was a problem hiding this comment.
Yes, you are indeed correct.
I'll create a separate subfolder for internal monitoring.
cowprotocol/solver_dashboard/number_capped_reward_batches_3670624.sql
Outdated
Show resolved
Hide resolved
| sum(consistency_reward) as consistency_reward, | ||
| sum(quote_reward) as quote_reward, | ||
| sum(performance_reward + consistency_reward + coalesce(quote_reward, 0)) as total_reward | ||
| from query_3641173 |
There was a problem hiding this comment.
Same comment as above. If the query you reference is not part of this repo, please add it as well.
There was a problem hiding this comment.
Same issue, same answer. I'll add the query
cowprotocol/solver_dashboard/solver_failures_rate_by_environment_1372870.sql
Show resolved
Hide resolved
|
@PoloX2021 Very nice work! Added a few more comments but overall looks very good! |
|
@PoloX2021 Did some minor edits and fixes. Could you fix the remaining issues so that we merge this? |
Adds all the queries from 2 dune solver dashboards:
Solver Info
Competition Monitoring
The first dashboards has the following 10 queries. The first 5 have been updated and adapted to fit every chain. "Solver_rewards_total" has yet to be revised but that is more complex and being tackled. The 4 last ones are not relevant for now, awaiting the new tables on dune (batch and trades) for other chains.
active_solvers
batch_settlement_info
daily_solver_stats
ranked_active_solvers
solver_failure_rates_by_env
solver_rewards_total: yet to be revised
cost_coverage_by_solver_environment: no longer useful as there are no more fees
cost_coverage_production_solver: no longer useful as there are no more fees
cow_rewards_total: up to date, ready to be extended to other chains
solver_yields: not useful
The second has the 2 following. No modification from the dashboard were added.
number_capped_reward_batches
protocol_weekly_rewards
There is an issue with sqlfluff for linting, as it does not process correcty the parameters from dune sql