Update CoW AMM bounty query to handle uncatalogued solvers #67
Conversation
There was a problem hiding this comment.
The changes look reasonable.
We are moving into the realm of duplicate code with this, however.
Regarding the bugL: How can we make sure that our queries do not randomly remove results due to spells not getting updated? In general, we can try to avoid using solver names in anything but a final table for pretty printing. In the query at hand, though, this was not possible since using solver names is the most viable approach due to multiple chains (and multiple environments) being involved.
|
Since this is a temporary query, i wouldn't really be worried too much about duplicated code. If we decide to proceed with vouching on multiple chains, then indeed we could only work with addresses and then these problems would be gone. |
The current version of the query is removing solvers that do not have their name "registered" on Dune. This PR addresses this by replacing an "Uncatalogued" solver name with the corresponding solver address, so that the solver is still included int he final results
Query has already been updated as it was needed for today's payout.
https://dune.com/queries/4031724?cow_budget_n26d66=28650&start_time_d83555=2024-11-12+00%3A00%3A00&end_time_d83555=2024-11-19+00%3A00%3A00