Use new orders tables for fees for slippage #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2024
Closed
harisang
approved these changes
Dec 13, 2024
harisang
added a commit
to cowprotocol/solver-rewards
that referenced
this pull request
Dec 14, 2024
This PR enables slippage computations on all chains. It extends #447 to also pass the blockchain parameter to the slippage query and log some results. At the moment it uses query 4379621 instead of 3427730. This change can be reverted once cowprotocol/dune-queries#87 is merged. --------- Co-authored-by: Haris Angelidakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds correct handling of fees on chains other than mainnet to slippage.
Before this change, all buffer changes were treated as slippage. With this change, network and protocol fees are correctly accounted for and excluded from slippage.
This should only be merged after merging #80 since query 4364122 is used.