Add new full bonding pools #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Dec 16, 2024
| @@ -3,19 +3,29 @@ | |||
| with | |||
| full_bonding_pools as ( | |||
| select | |||
| from_hex('0x8353713b6D2F728Ed763a04B886B16aAD2b16eBD') as pool_address, | |||
| from_hex('0x8353713b6D2F728Ed763a04B886B16aAD2b16eBD') as pool_address, -- deprecated | |||
There was a problem hiding this comment.
Should we rename this to deprecated? Having Gnosis vs Gnosis DAO seems a bit awkwardly implicit
There was a problem hiding this comment.
You mean, have the name of the pool being "Deprecated"?
The slight change from Gnosis to Gnosis DAO was just to make it uniform with the CoW DAO pool naming, and was not meant to differentiate the old with the new.
(E.g., Project Blanc is still Project Blanc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new full bonding pools:
It also renames the
initial_fundercolumn tocreator, as it is more accurate (creator is what we are interested in as this is the address that can vouch, while there can be multiple funders)