add protocol fee by order class query #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Dec 20, 2024
| with | ||
| protocol_fees_collected as ( | ||
| select --noqa: ST06 | ||
| order_uid, --noqa: RF03 |
There was a problem hiding this comment.
it honestly sounds weird to me that we need a noqa comment on every line here. What exactly is the problem? Can this be resolved by slightly renaming of the select clauses?
There was a problem hiding this comment.
I believe the complaint is due to the dictionary structure of the data part of cowswap.raw_order_rewards. This will go away with a follow-up PR that will make the query use the new raw order data table.
cowprotocol/accounting/fees/protocol_fees_by_order_class_3703312.sql
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds query https://dune.com/queries/3703312
under version control.
Some minimal changes and clean-up have been made