Update and extend unusual slippage query to all chains #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Nice, would it be possible to add a column with "network + protocol fee" to this table? This would make it easier to review as from the phalcon link I get the total slippage (including fee) from which I have to deduct the fee in order to check if the value align with our slippage accounting.
cowprotocol/accounting/rewards/mainnet/unusual_slippage_query_2332678.sql
Outdated
Show resolved
Hide resolved
cowprotocol/accounting/rewards/mainnet/unusual_slippage_query_2332678.sql
Outdated
Show resolved
Hide resolved
…2332678.sql Co-authored-by: Felix Leupold <[email protected]>
…2332678.sql Co-authored-by: Felix Leupold <[email protected]>
Will address it in a follow-up PR. Opened a relevant issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the outdated version of the query that was in this repo (the phalcon explorer view link was missing) and also extends it to work for all chains.
Changes have already been applied and can be tested here:
https://dune.com/queries/2332678?start_time_d83555=2024-12-10+00%3A00%3A00&end_time_d83555=2024-12-17+00%3A00%3A00