This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Remove restriction on quote rewards for limit orders #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change only market orders were eligible for quote rewards and only in that case a quote_solver was fetched. with this change, a quote_solver is always fetched (if it exists)
harisang
approved these changes
Jan 4, 2024
|
@fhenneke Should we go ahead and merge this PR to check whether data is properly synced on Dune? And once things look good, we can proceed with merging cowprotocol/solver-rewards#328 |
harisang
added a commit
to cowprotocol/solver-rewards
that referenced
this pull request
Jan 10, 2024
When switching to all orders being limit orders we need to adapt how we compute quote rewards. At the moment, only market orders are eligible for quote rewards. With the current code this would mean that no quotes would receive rewards. This PR removes testing the kind of an order when querying for quote solvers. This means that all quotes associated with executed orders are elibible for rewards. The impact of rewarding more quotes is expected to be small. This change has to be done merged toether with a [PR](cowprotocol/dune-sync#59) on syncing quote solvers to dune. --------- Co-authored-by: harisang <[email protected]> Co-authored-by: Haris Angelidakis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to be merged together with this PR to sync the correct quote solver to dune. Context is in the other PR.